Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NA): eui submodule paths in ui-shared-deps-* #202056

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

fix(NA): eui submodule paths in ui-shared-deps-* #202056

wants to merge 30 commits into from
+9 −8

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 27, 2024 •
edited
Loading

This PR fixes what was introduced at #199748.

@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 labels Nov 27, 2024
@mistic mistic marked this pull request as ready for review November 27, 2024 19:10
@mistic mistic requested a review from a team as a code owner November 27, 2024 19:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic force-pushed the test-fix-theme-loader-shared-deps branch from 73e2e74 to 25b9c23 Compare December 2, 2024 06:23
@mistic mistic self-assigned this Dec 2, 2024
@elastic elastic deleted a comment from elasticmachine Dec 12, 2024
@tkajtoch tkajtoch self-requested a review December 18, 2024 11:44
@mistic mistic requested a review from a team as a code owner December 24, 2024 01:30
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
advancedSettings 122 121 -1
aiops 630 629 -1
alerting 246 245 -1
apm 1930 1929 -1
banners 45 44 -1
canvas 1293 1292 -1
cases 828 827 -1
cloudDataMigration 34 33 -1
cloudLinks 90 89 -1
cloudSecurityPosture 662 661 -1
console 237 236 -1
core 422 421 -1
crossClusterReplication 135 134 -1
dashboardEnhanced 109 108 -1
data 535 534 -1
dataQuality 92 91 -1
dataUsage 145 144 -1
dataViewEditor 98 97 -1
dataViewFieldEditor 174 173 -1
dataViewManagement 250 249 -1
dataVisualizer 733 732 -1
devTools 45 44 -1
discover 947 946 -1
embeddable 122 121 -1
enterpriseSearch 2310 2309 -1
entityManagerApp 46 45 -1
eventAnnotationListing 639 638 -1
exploratoryView 184 183 -1
expressionGauge 119 118 -1
expressionHeatmap 231 230 -1
expressionLegacyMetricVis 59 58 -1
expressionMetricVis 164 163 -1
expressionPartitionVis 248 247 -1
expressionTagcloud 219 218 -1
expressionXY 309 308 -1
filesManagement 201 200 -1
fleet 1253 1252 -1
globalSearchBar 58 57 -1
graph 313 312 -1
grokdebugger 53 52 -1
guidedOnboarding 54 53 -1
home 269 268 -1
imageEmbeddable 154 153 -1
indexLifecycleManagement 264 263 -1
indexManagement 700 699 -1
infra 1300 1299 -1
ingestPipelines 358 357 -1
inputControlVis 107 106 -1
inspector 90 89 -1
interactiveSetup 70 69 -1
inventory 259 258 -1
kibanaOverview 139 138 -1
kibanaReact 219 218 -1
lens 1556 1555 -1
licenseManagement 127 126 -1
licensing 41 40 -1
links 144 143 -1
logstash 77 76 -1
management 132 131 -1
metricsDataAccess 305 304 -1
mockIdpPlugin 47 46 -1
monitoring 501 500 -1
navigation 89 88 -1
newsfeed 39 38 -1
observability 1111 1110 -1
observabilityLogsExplorer 213 212 -1
observabilityOnboarding 257 256 -1
osquery 347 346 -1
painlessLab 57 56 -1
presentationPanel 124 123 -1
profiling 314 313 -1
remoteClusters 127 126 -1
reporting 165 164 -1
rollup 148 147 -1
runtimeFields 46 45 -1
savedObjects 48 47 -1
savedObjectsManagement 124 123 -1
savedObjectsTagging 118 117 -1
searchHomepage 154 153 -1
searchIndices 245 244 -1
searchInferenceEndpoints 163 162 -1
searchPlayground 271 270 -1
searchprofiler 91 90 -1
security 529 528 -1
securitySolution 6477 6476 -1
serverless 90 89 -1
serverlessSearch 312 311 -1
share 103 102 -1
slo 864 863 -1
snapshotRestore 213 212 -1
spaces 340 339 -1
streamsApp 169 168 -1
synthetics 1061 1060 -1
telemetry 66 65 -1
timelines 187 186 -1
transform 488 487 -1
triggersActionsUi 870 869 -1
uiActions 52 51 -1
unifiedSearch 387 386 -1
upgradeAssistant 171 170 -1
uptime 592 591 -1
ux 207 206 -1
visDefaultEditor 255 254 -1
visTypeMarkdown 44 43 -1
visTypeTable 62 61 -1
visTypeTimelion 78 77 -1
visTypeTimeseries 509 508 -1
visTypeVislib 138 137 -1
visualizations 494 493 -1
watcher 191 190 -1
total -110

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ui-shared-deps-src 52 51 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 621.4KB 619.6KB -1.8KB
alerting 101.6KB 101.1KB -460.0B
apm 5.6MB 5.6MB -424.0B
canvas 1.1MB 1.1MB -456.0B
cloudDataMigration 6.6KB 6.1KB -460.0B
cloudSecurityPosture 503.4KB 503.0KB -456.0B
controls 495.2KB 495.2KB -2.0B
crossClusterReplication 147.5KB 147.0KB -460.0B
dashboard 668.6KB 669.0KB +460.0B
dataQuality 29.2KB 28.7KB -460.0B
dataUsage 243.8KB 243.4KB -457.0B
dataViewManagement 140.8KB 140.4KB -457.0B
dataVisualizer 615.4KB 613.1KB -2.2KB
devTools 8.7KB 8.2KB -460.0B
discover 786.9KB 786.5KB -453.0B
enterpriseSearch 2.6MB 2.6MB -452.0B
entityManagerApp 12.2KB 11.7KB -460.0B
eventAnnotationListing 232.3KB 231.8KB -457.0B
exploratoryView 184.0KB 183.6KB -460.0B
filesManagement 126.1KB 125.6KB -457.0B
graph 418.8KB 418.4KB -457.0B
grokdebugger 11.7KB 11.2KB -437.0B
home 153.0KB 152.6KB -457.0B
imageEmbeddable 70.5KB 69.6KB -920.0B
indexLifecycleManagement 166.8KB 166.4KB -457.0B
infra 1.3MB 1.3MB -912.0B
inputControlVis 52.8KB 52.3KB -460.0B
inventory 234.6KB 234.1KB -457.0B
kibanaOverview 66.0KB 65.5KB -461.0B
lens 1.5MB 1.5MB -457.0B
licenseManagement 47.5KB 47.0KB -457.0B
links 48.8KB 48.3KB -460.0B
logstash 34.3KB 33.9KB -460.0B
management 49.2KB 48.8KB -457.0B
maps 3.0MB 3.0MB +461.0B
metricsDataAccess 100.2KB 99.7KB -457.0B
ml 4.7MB 4.7MB -3.6KB
monitoring 538.9KB 538.5KB -457.0B
observabilityLogsExplorer 148.6KB 148.2KB -457.0B
observabilityOnboarding 274.8KB 274.4KB -457.0B
painlessLab 19.3KB 18.8KB -460.0B
profiling 406.9KB 406.4KB -461.0B
remoteClusters 80.2KB 79.7KB -460.0B
rollup 116.5KB 116.0KB -457.0B
savedObjectsManagement 87.7KB 87.2KB -460.0B
searchHomepage 55.9KB 55.4KB -457.0B
searchIndices 170.3KB 169.8KB -461.0B
searchInferenceEndpoints 99.7KB 99.2KB -461.0B
searchPlayground 165.1KB 164.7KB -461.0B
searchprofiler 49.5KB 49.1KB -460.0B
securitySolution 21.4MB 21.4MB -3.1KB
serverlessSearch 372.2KB 370.9KB -1.3KB
slo 852.6KB 850.8KB -1.8KB
snapshotRestore 264.1KB 263.6KB -460.0B
streamsApp 115.1KB 114.7KB -457.0B
synthetics 1.1MB 1.1MB -919.0B
timelines 33.4KB 33.0KB -460.0B
transform 476.4KB 476.0KB -460.0B
triggersActionsUi 1.7MB 1.7MB -5.0KB
uptime 467.5KB 467.0KB -455.0B
ux 168.2KB 167.8KB -460.0B
visTypeVega 1.9MB 1.9MB +459.0B
watcher 167.4KB 166.9KB -460.0B
total -42.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
advancedSettings 8.2KB 7.8KB -380.0B
aiops 17.5KB 17.5KB +77.0B
alerting 25.8KB 25.8KB +77.0B
apm 38.5KB 38.6KB +77.0B
banners 11.2KB 10.8KB -380.0B
canvas 14.6KB 14.6KB +77.0B
cases 160.3KB 159.9KB -380.0B
cloudDataMigration 4.8KB 4.8KB +77.0B
cloudLinks 31.0KB 30.6KB -380.0B
cloudSecurityPosture 18.0KB 18.0KB +77.0B
console 39.0KB 38.6KB -380.0B
controls 14.3KB 14.3KB +77.0B
core 447.7KB 447.3KB -380.0B
crossClusterReplication 12.4KB 12.5KB +77.0B
dashboard 52.4KB 52.0KB -380.0B
dashboardEnhanced 18.7KB 18.3KB -380.0B
data 421.7KB 421.3KB -380.0B
dataQuality 8.5KB 8.6KB +77.0B
dataUsage 7.7KB 7.7KB +77.0B
dataViewEditor 14.3KB 13.9KB -380.0B
dataViewFieldEditor 27.5KB 27.1KB -380.0B
dataViewManagement 5.2KB 5.3KB +77.0B
dataVisualizer 26.3KB 26.3KB +77.0B
devTools 11.2KB 11.3KB +77.0B
discover 45.2KB 45.3KB +77.0B
embeddable 34.8KB 34.4KB -380.0B
enterpriseSearch 52.2KB 52.3KB +77.0B
entityManagerApp 5.0KB 5.1KB +77.0B
eventAnnotationListing 11.0KB 11.1KB +77.0B
exploratoryView 44.1KB 44.2KB +77.0B
expressionGauge 17.0KB 16.7KB -380.0B
expressionHeatmap 17.9KB 17.6KB -380.0B
expressionLegacyMetricVis 13.2KB 12.9KB -380.0B
expressionMetricVis 17.6KB 17.2KB -380.0B
expressionPartitionVis 29.9KB 29.5KB -380.0B
expressionTagcloud 14.0KB 13.6KB -380.0B
expressionXY 42.8KB 42.4KB -380.0B
filesManagement 4.1KB 4.2KB +77.0B
fleet 174.2KB 173.8KB -380.0B
globalSearchBar 30.6KB 30.2KB -380.0B
graph 8.2KB 8.2KB +77.0B
grokdebugger 4.6KB 4.7KB +77.0B
guidedOnboarding 30.4KB 30.0KB -380.0B
home 11.6KB 11.7KB +77.0B
imageEmbeddable 6.0KB 6.0KB +77.0B
indexLifecycleManagement 27.7KB 27.8KB +77.0B
indexManagement 47.7KB 47.3KB -380.0B
infra 51.1KB 51.2KB +77.0B
ingestPipelines 18.4KB 18.0KB -380.0B
inputControlVis 8.3KB 8.4KB +77.0B
inspector 25.7KB 25.3KB -380.0B
interactiveSetup 60.5KB 60.1KB -380.0B
inventory 13.2KB 13.3KB +77.0B
kbnUiSharedDeps-npmDll 5.9MB 6.0MB +56.3KB
kbnUiSharedDeps-srcJs 3.5MB 3.5MB -58.7KB
kibanaOverview 5.4KB 5.4KB +77.0B
kibanaReact 40.0KB 39.6KB -380.0B
lens 50.4KB 50.5KB +77.0B
licenseManagement 11.4KB 11.4KB +77.0B
licensing 12.4KB 12.1KB -380.0B
links 16.8KB 16.9KB +77.0B
logstash 14.3KB 14.3KB +77.0B
management 10.8KB 10.9KB +77.0B
maps 55.1KB 54.8KB -380.0B
metricsDataAccess 44.4KB 44.4KB +77.0B
ml 77.8KB 77.8KB +12.0B
mockIdpPlugin 10.6KB 10.2KB -380.0B
monitoring 25.7KB 25.8KB +77.0B
navigation 18.3KB 17.9KB -380.0B
newsfeed 13.5KB 13.1KB -380.0B
observability 105.2KB 104.8KB -380.0B
observabilityLogsExplorer 15.2KB 15.2KB +77.0B
observabilityOnboarding 10.5KB 10.6KB +77.0B
osquery 47.8KB 47.5KB -380.0B
painlessLab 10.3KB 10.4KB +77.0B
presentationPanel 43.9KB 43.6KB -380.0B
profiling 17.7KB 17.8KB +77.0B
remoteClusters 9.2KB 9.3KB +77.0B
reporting 51.1KB 50.7KB -380.0B
rollup 12.2KB 12.3KB +77.0B
runtimeFields 14.6KB 14.2KB -380.0B
savedObjects 18.3KB 17.9KB -380.0B
savedObjectsManagement 20.0KB 20.1KB +77.0B
savedObjectsTagging 23.3KB 22.9KB -380.0B
searchHomepage 4.8KB 4.9KB +77.0B
searchIndices 7.7KB 7.8KB +77.0B
searchInferenceEndpoints 6.3KB 6.4KB +77.0B
searchPlayground 7.0KB 7.1KB +77.0B
searchprofiler 15.7KB 15.8KB +77.0B
security 69.1KB 68.7KB -380.0B
securitySolution 88.0KB 88.1KB +77.0B
serverless 15.1KB 14.8KB -380.0B
serverlessSearch 23.0KB 23.0KB +77.0B
share 58.3KB 58.0KB -380.0B
slo 29.8KB 29.9KB +77.0B
snapshotRestore 27.3KB 27.4KB +77.0B
spaces 35.4KB 35.0KB -380.0B
streamsApp 5.5KB 5.6KB +77.0B
synthetics 37.8KB 37.9KB +77.0B
telemetry 25.6KB 25.2KB -380.0B
timelines 202.0KB 202.1KB +77.0B
transform 18.5KB 18.6KB +77.0B
triggersActionsUi 127.1KB 127.2KB +77.0B
uiActions 24.7KB 24.4KB -380.0B
unifiedSearch 38.9KB 38.6KB -380.0B
upgradeAssistant 25.4KB 25.1KB -380.0B
uptime 22.9KB 22.9KB +77.0B
ux 7.0KB 7.1KB +77.0B
visDefaultEditor 24.7KB 24.4KB -380.0B
visTypeMarkdown 10.4KB 10.1KB -380.0B
visTypeTable 19.9KB 19.6KB -380.0B
visTypeTimelion 14.2KB 13.8KB -380.0B
visTypeTimeseries 21.2KB 20.8KB -380.0B
visTypeVega 45.7KB 45.4KB -380.0B
visTypeVislib 15.8KB 15.4KB -380.0B
visualizations 65.6KB 65.2KB -380.0B
watcher 13.7KB 13.8KB +77.0B
total -18.4KB
Unknown metric groups

API count

id before after diff
@kbn/ui-shared-deps-src 61 60 -1

History

cc @mistic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

@tkajtoch tkajtoch Awaiting requested review from tkajtoch

Assignees

@mistic mistic

Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistic @elasticmachine @Ikuni17 @kibanamachine